Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix migration dependency for @aws/pdk/monorepo (not nx-monorepo) #589

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(docs): fix migration dependency for @aws/pdk/monorepo (not nx-monorepo) #589

merged 1 commit into from
Oct 4, 2023

Conversation

walmsles
Copy link
Contributor

@walmsles walmsles commented Oct 1, 2023

Fixes #588

Update migration diff in step 2 of the migration to @aws/pdk/monorepo. The existing diff still has the change as @aws/pdk/nx-monorepo which is incorrect.

agdimech
agdimech approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@agdimech agdimech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch - thank you so much!

@agdimech agdimech merged commit b4f5e0f into aws:mainline Oct 4, 2023
3 checks passed
@walmsles walmsles deleted the fix/migration-docs branch October 14, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agdimech agdimech agdimech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] (Migration Step 2 references @aws/pdk/nx-monorepo incorrectly)
2 participants
@walmsles @agdimech